fix(ui): unify mobile Source Control row density across Queue, List, and Tree - #156
Open
ClaudiaFang wants to merge 1 commit into
Open
fix(ui): unify mobile Source Control row density across Queue, List, and Tree#156ClaudiaFang wants to merge 1 commit into
ClaudiaFang wants to merge 1 commit into
Conversation
…and Tree Queue rows already set the compact mobile row baseline; List and Tree file rows, plus tree folder rows, now read the same shared --scv-mobile-row-* custom properties instead of drifting independently. List mode's folder-path suffix now yields horizontal space before the filename (disproportionate flex-shrink) so long paths ellipsis first and the row never wraps to a second line. Also normalizes the Queue→Repository vertical gap and both sections' header→first-row padding to the same values. CSS-only; no changes to SourceControlViewModel, selection semantics, sync behavior, tree shaping, scroll persistence, or Queue/Repository responsibilities.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--scv-mobile-row-min-height/--scv-mobile-row-paddingon.scv-root) so Sync Queue rows, Repository List rows, Repository Tree file rows, and tree folder rows all read the same compact height/padding instead of drifting independently..scv-change-item-liststays a single non-wrapping row:.scv-change-pathnow yields horizontal space first (disproportionateflex-shrink) so the folder path ellipses before the filename does, andflex-wrap: nowrap+overflow: hiddenguard the row against any wrap-driven height growth..scv-body, not overlaid) — added a structural regression test rather than a code change.CSS-only (
styles.css); no changes toSourceControlViewModel, selection semantics, sync behavior, tree shaping, scroll persistence, or Queue/Repository responsibilities.Test plan
npx eslint .— 0 errorsnpx vitest run— 76 files / 958 tests passed (5 new structural tests added inSourceControlView.test.ts: row-density parity across Queue/Tree/List, single-row list-mode content, tree-mode path omission, folder-row class sharing, sync-bar single-instance/placement)npm run build(tsc + Obsidian 1.11.0 compat typecheck + esbuild) — passedstyles.cssor compute layout